Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Refactoring hiero #648 PR to pype3 #907

Merged
merged 14 commits into from
Feb 2, 2021

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Jan 21, 2021

take content of changes from #648 and convert to pype3 as the original PR is fo 2xDev

Also new host folder structure will by applied:

├───hiero
│   ├───api
│   ├───plugins
│   └───startup
  • refactoring Tag workflow - removing json, adding pype tag for single taging
  • adding functions to lib for plugin wide use
  • Creator with gui and renamer for hierarchical data use
  • Publishing plugins refactoring for single tag collection
  • Collectors in publishing refactoring for pre-collecting faze of publisher
  • Loading clip to timeline with update and remove, containerized and activated Manage menu item

What to test in Shot Creator plugin ui?

  • Renaming with Hiero tool and only generating tag in one layer > select clips in single layer which are renamed with hiero's build in renaming tool (select clips / Editorial / Rename) and check if the P. Tag was created with correct asset. It should be the same as the original name of clip after rename > Rename clips False
  • Renaming with tool and layer names defining subset names with vertical synchronization > create clips in multiple layers. Rename layers to subset name. Slips should be exactly above each other. Select all clips in layers. In UI panel set > Vertical rename True, Master track (Usually main), Subset name <track_name>
  • Renaming with tool and no vertical synchronization used (if all clips across layers are individual assets) > Vertical rename False, Subset name main
  • also implemented Hiero: cut videos with correct secons  #892

@mkolar mkolar added type: enhancement Enhancements to existing functionality backend labels Jan 22, 2021
@mkolar mkolar mentioned this pull request Jan 22, 2021
6 tasks
@jakubjezek001 jakubjezek001 linked an issue Jan 22, 2021 that may be closed by this pull request
@mkolar mkolar added this to the 3.0 milestone Jan 22, 2021
@mkolar mkolar self-requested a review February 2, 2021 10:46
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this to get all the hosts on par in terms of structure. But it will need work as discussed. Multiple things are not working quite right, but There's probably no sense in fixing them before unifying the behaviour with resolve.

@mkolar mkolar merged commit f87081b into develop Feb 2, 2021
@mkolar mkolar deleted the feature/906-hiero-convert-to-pype3 branch February 10, 2021 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Hiero type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hiero convert to pype3
2 participants